gitbook

branching-model

For the team we will be using the branching model described here. You should take some time and read it carefully. Essentially, this means that on each branch you will be working on a single functionality.

You can create a new branch by using the command:

git checkout -b <newbranch> <basebranch>

TL;DR:

In origin:

  • indigo - the stable branch.

  • devel - the development branch, where approved merge requests are integrated.

  • release-X.Y: the release branch, where preparations are made right before merging into indigo.

In your remote:

  • feature/[meta]/nameoffeature: New functionality that will be added to the robot.

  • fix/X.Y.Z: Fixing a bug that was found in existing code.

    Where [meta] will refer to the metapackage where your feature or bug belongs.

Features

Naming Convention:feature/[meta]/nameoffeature Where [meta] will refer to the metapackage where your feature will be included:

  • manipulation

  • navigation

  • perception

  • planning

  • speech

  • scenario

Some basic rules:

  • Every feature gets its own branch.

  • Branches off from devel

  • Merges into devel

To create a feature branch:

git checkout -b feature/[meta]/nameoffeature devel

To merge a feature branch:

  1. Make sure you have the latest changes in devel

    git checkout devel
git pull origin devel

  2. Merge devel into your branch

    git checkout feature/[meta]/nameoffeature
git merge devel

  3. Update the changelog:

    catkin_generate_changelog --skip-merge

  4. Create a merge request using the web version of gitgate.

  5. Once your merge request is accepted, delete your branch

    git branch -d feature/[meta]/nameoffeature

Bug fixes

Naming Convention: fix/issue-NNN Where NNN is the issue number reflecting the bug.

Some basic rules:

  • Every bug gets its own branch.

  • Branches off from indigo

  • Merges into indigo and devel

To create a fix branch:

git checkout -b fix/issue-NNN indigo

Work on your bug fix and commit your changes. When you have tested and have satisfactory results, create merge requests to both indigo and devel:

  1. To merge a fix branch, first update the changelog:

    catkin_generate_changelog --skip-merge

  2. Create a merge request for indigo using the web interface of gitgate. <!--3. Once it is approved, the version number needs to be updated:

    catkin_prepare_release
git commit -a -m "Bumped version number to X.Y.Z"

    -->

  3. Finally, create a merge request either in the release branch (if it exists) or in devel. Note: DO NOT merge on both.

  4. Once your merge request gets accepted, delete your branch.

    git branch -d fix/issue-NNN

Release branches

Naming Convention: release/X.Y.Z Where X represents a major release, e.g.

  • migrating to a new ROS version

  • code integrated after a competition

  • code from several R&D and theses projects, usually at the end of a semester

And Y represents a minor release, e.g.

  • a single R&D project or thesis

  • a significant improvement in a functionality

  • a new scenario

This will only take place on the stable repository, not on your remote. Some basic rules:

  • Branches off from devel

  • Merges into indigo and devel

To create a release branch:

git checkout -b release/X.Y.Z devel

During the next two months after the release, regular testing needs to take place and any bug fixes need to be taken care of. After the release is stable enough, it will be merged back into indigo. If you have read this far, send me an email with a picture of your favorite robot to get a candy after our next meeting.

To merge a release branch, first update the changelog:

catkin_generate_changelog --skip-merge
catkin_prepare_release --bump <major, minor, patch>
git commit -a -m "Bumped version number to X.Y.Z"

Then merge back into indigo and devel

git checkout indigo
git merge --no-ff release/X.Y.Z
git tag -a X.Y

# Merge into devel as well
git checkout devel
git merge --no-ff release/X.Y.Z

In case of merge conflicts or issues (most likely because of the change in version number), fix them, commit your changes and then delete your branch:

git branch -d release/X.Y.Z

Merge requests

First take a look at the merge request diagram here. Some rules:

  • Before pushing, take a look at your commit history.

    Once you have pushed your commits to your repository, any changes you make to the commits themselves will be risky. If anybody has already pulled your changes, modifications will probably cause issues.

  • You probably will need to squash some, if not all, of your commits in order to make the descriptions coherent. You can find an example on how to do it locally and in your branch (Not recommended, do it only if strictly necessary).

    DO NOT squash your commits once they have been merged into the stable branch.

  • Before creating a merge request, take a look at how the CHANGELOG.rst looks like.

    In case your commits were not ideal, you will have to edit the CHANGELOG.rst manually. This is not recommended.

  • Fill out the template according to the changes you are making.

See also

PreviousgitNextcommits

Last updated